tommy/cos-go-sdk-v5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add the comment to declare the out of memory issue when put large local file

Browse Source
This commit is contained in:
toranger
2019-01-31 19:08:28 +08:00
parent bf9ab1f8a7
commit 6c894b8e4d
3 changed files with 19 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
object.go
View File

@@ -105,17 +105,17 @@ func (s *ObjectService) Put(ctx context.Context, name string, r io.Reader, opt *
return resp, err
}
// TODO Not Suggest use for now, need to improve
// PutFromFile put object from local file
// func (s *ObjectService) PutFromFile(ctx context.Context, name string, filePath string, opt *ObjectPutOptions) (*Response, error) {
// fd, err := os.Open(filePath)
// if err != nil {
// return nil, err
// }
// defer fd.Close()
// Notice that when use this put large file need set non-body of debug req/resp, otherwise will out of memory
func (s *ObjectService) PutFromFile(ctx context.Context, name string, filePath string, opt *ObjectPutOptions) (*Response, error) {
fd, err := os.Open(filePath)
if err != nil {
return nil, err
}
defer fd.Close()
// return s.Put(ctx, name, fd, opt)
// }
return s.Put(ctx, name, fd, opt)
}
// ObjectCopyHeaderOptions is the head option of the Copy
type ObjectCopyHeaderOptions struct {